Skip to content

fix(vcs): compute default url for github #6250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix(vcs): compute default url for github #6250

merged 1 commit into from
Aug 5, 2022

Conversation

yesnault
Copy link
Member

@yesnault yesnault commented Aug 4, 2022

Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com

@yesnault
fix(vcs): compute default url for github
c5c9e28 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 4, 2022

CDS Report build-all-cds#17721.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 4, 2022

CDS Report build-all-cds#17721.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@yesnault yesnault merged commit 706e7f2 into master Aug 5, 2022
@yesnault yesnault deleted the ye-vcs-defv branch September 20, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamin fsamin fsamin approved these changes

@richardlt richardlt Awaiting requested review from richardlt richardlt is a code owner

@sguiheux sguiheux Awaiting requested review from sguiheux sguiheux is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yesnault @ovh-cds @fsamin