Skip to content

feat(api,hooks): add v2 hook signature and github repository analysis #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 26, 2022
Merged

feat(api,hooks): add v2 hook signature and github repository analysis #6255

merged 12 commits into from
Aug 26, 2022

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@sguiheux sguiheux marked this pull request as ready for review August 23, 2022 15:24
yesnault
yesnault reviewed Aug 25, 2022
View reviewed changes
@sguiheux @yesnault
Update engine/api/v2_project.go
09c3776 
Co-authored-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
fsamin
fsamin requested changes Aug 25, 2022
View reviewed changes
engine/hooks/hooks_router.go
}

// Create a new HMAC by defining the hash type and the key (as byte array)
h := hmac.New(sha256.New, []byte(hook.HookSignKey))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is it time consuming ?

Copy link
Collaborator Author

@sguiheux sguiheux Aug 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the middleware: 35ms with a gitea event on a local environment

richardlt
richardlt reviewed Aug 25, 2022
View reviewed changes
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 25, 2022

CDS Report build-all-cds#17801.0 ✘

  • Build
    • Build and Package All ✘
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

fsamin
fsamin requested changes Aug 25, 2022
View reviewed changes
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

44.1% 44.1% Coverage
0.0% 0.0% Duplication

@sguiheux sguiheux merged commit 458912c into master Aug 26, 2022
@sguiheux sguiheux deleted the hookSignatureV2 branch September 5, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt