Skip to content

refactor(ui): remove semantic from workflow/notification/workflowAdm #6232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 8, 2022
Merged

refactor(ui): remove semantic from workflow/notification/workflowAdm #6232

merged 10 commits into from
Jul 8, 2022

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Jul 7, 2022

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

richardlt
richardlt reviewed Jul 7, 2022
View reviewed changes
@sguiheux @richardlt
Update ui/src/app/views/workflow/show/admin/workflow.admin.component.ts
13f9080 
Co-authored-by: Richard LT <richard.le.terrier@gmail.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 7, 2022

CDS Report build-all-cds#17624.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

2.6% 2.6% Coverage
0.0% 0.0% Duplication

@richardlt richardlt merged commit be65926 into master Jul 8, 2022
@sguiheux sguiheux deleted the removeSemanticFromWorkflow branch July 8, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin Awaiting requested review from fsamin fsamin is a code owner

@yesnault yesnault Awaiting requested review from yesnault yesnault is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sguiheux @ovh-cds @richardlt