Skip to content

feat(api): validate yml plugin before import it #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2020
Merged

feat(api): validate yml plugin before import it #5378

merged 2 commits into from
Aug 18, 2020

Conversation

yesnault
Copy link
Member

@yesnault yesnault commented Aug 17, 2020 •
edited
Loading

close #5329
Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com

@yesnault
feat(api): validate yml plugin before import it
02a8c34 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: cr
5200818 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 17, 2020

CDS Report build-all-cds#14140.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 17, 2020

CDS Report build-all-cds#14140.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Sonar ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘
    • Standalone tests 1 -
    • Standalone tests 2 -
    • Standalone tests 3 -

@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 18, 2020

CDS Report build-all-cds#14140.2 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Sonar ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘
    • Standalone tests 1 -
    • Standalone tests 2 -
    • Standalone tests 3 -

@yesnault yesnault merged commit 6beace0 into master Aug 18, 2020
@yesnault yesnault deleted the ye-fix-5329 branch August 18, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin Awaiting requested review from fsamin fsamin is a code owner

@sguiheux sguiheux Awaiting requested review from sguiheux sguiheux is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes integration with CDS error
3 participants
@yesnault @ovh-cds @richardlt