feat(hatchery/openstack): check flavor #5148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
fsamin
requested changes
Apr 27, 2020
| // if there is a model, we have to check if the flavor attached to model is knowned by this hatchery | ||
| if model != nil { | ||
| if _, err := h.flavorID(model.ModelVirtualMachine.Flavor); err != nil { | ||
| log.Debug("CanSpawn> flavor '%s' not found", model.ModelVirtualMachine.Flavor) |
There was a problem hiding this comment.
it could be nice to check the error
There was a problem hiding this comment.
sorry, i don't see how you are checking the error is "flavor not found"
|
CDS Report build-all-cds#13083.0 ✘
|
richardlt
approved these changes
Apr 27, 2020
fsamin
approved these changes
Apr 28, 2020
sguiheux
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.