This repository was archived by the owner on Feb 27, 2020. It is now read-only.
Disable project-history via settings #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
das7pad
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
The flag is also used in the RedisManager [0] to skip the queuing of ops into redis.
The queue is not consumed by any OSS service. Maybe add a migration script to free the queue items? This could be an EXPIRE call on the queue key with an arbitrary high value to give the server pro services time to pick up any old items. Newly queued items are not impacted by the EXPIRE call.
JuneKelly
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables
project-historyservice call. Flag is used bydocument-updaterto flush changes after deletion https://github.com/overleaf/document-updater/blob/master/app/coffee/HistoryManager.coffee#L30Fixes overleaf/overleaf#644.