Skip to content

Stop keeping track of the names of unpacked files #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

Stop keeping track of the names of unpacked files #334

merged 1 commit into from
Jan 5, 2023

Conversation

vrmiguel
Copy link
Member

@vrmiguel vrmiguel commented Jan 5, 2023

Since we only use the return of smart_unpack to print out the amount of unpacked files, we don't have to build the expensive Vec of unpacked PathBufs, instead only returning the actual number of unpacked files

figsoda
figsoda approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@figsoda figsoda merged commit b66932b into main Jan 5, 2023
@figsoda figsoda deleted the no-longer-save-unpacked-file-names branch January 5, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda figsoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrmiguel @figsoda