add cli option to (de)compress quietly #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
79ae508 to
0ceb84d
Compare
marcospb19
requested changes
Dec 19, 2022
Co-authored-by: João Marcos Bezerra <marcospb19@hotmail.com>
|
quoted from #294 (comment)
I think it's ok to have the argument being passed like this, eventually we'll refactor if it's a problem. I want to do some local testing here before merging, so I'll be giving another review when possible. |
marcospb19
approved these changes
Dec 24, 2022
There was a problem hiding this comment.
I tested it and everything seems to be OK, just a problem with the flag not being global.
ouch --quiet compress ... # This always works
ouch compress --quiet ... # This only works with 'global = true'
ouch compress ... --quiet # This only works with 'global = true'I'll fix this for --quiet and other flags too, but in another PR.
|
Thanks for the PR! 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #294