Skip to content

Check for errors when setting the last modified time #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2022
Merged

Check for errors when setting the last modified time #278

merged 3 commits into from
Oct 12, 2022

Conversation

marcospb19
Copy link
Member

@marcospb19 marcospb19 commented Oct 12, 2022 •
edited
Loading

This is #274 reopened.

This PR refactors the way we set the 'last modified time'
when unpacking a Zip archive.

Replacing the usage of libc and unsafe by the filetime crate.

@marcospb19 marcospb19 requested a review from figsoda October 12, 2022 00:28
@marcospb19 marcospb19 force-pushed the refactor-last-modified-times-when-unpacking-archives branch 2 times, most recently from 24e419b to 08ec218 Compare October 12, 2022 01:09
@marcospb19
Refactor the way we set last modified times
71893aa 
Last modified time is a piece of metadata that is available when
decompressing an archive
@marcospb19
minor tweaks
a2c91c4
@marcospb19
update changelog
acb7566
@marcospb19 marcospb19 force-pushed the refactor-last-modified-times-when-unpacking-archives branch from 08ec218 to acb7566 Compare October 12, 2022 01:10
figsoda
figsoda approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcospb19 marcospb19 merged commit e92b538 into main Oct 12, 2022
@marcospb19 marcospb19 mentioned this pull request Oct 12, 2022
Closed
@figsoda figsoda mentioned this pull request Oct 12, 2022
Merged
@figsoda figsoda deleted the refactor-last-modified-times-when-unpacking-archives branch October 12, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda figsoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcospb19 @figsoda