Skip to content

Check for errors when writing file times #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Check for errors when writing file times #274

wants to merge 5 commits into from

Conversation

marcospb19
Copy link
Member

This PR adds error treatment for when access and modification
times are written when decompressing an archive.

@marcospb19 marcospb19 force-pushed the check-file-times-errors branch from 6a915b6 to 6ae04fc Compare October 11, 2022 19:20
figsoda
figsoda approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm
another options is to use filetime which tar is also using, so we have less unsafes to maintain

@marcospb19 marcospb19 mentioned this pull request Oct 11, 2022
Closed
@marcospb19 marcospb19 force-pushed the check-file-times-errors branch 2 times, most recently from 3aec3a4 to b904853 Compare October 11, 2022 23:43
@marcospb19
Copy link
Member Author

@figsoda I force-pushed a new implementation that uses filetime and removes the two unsafe uses in this file.

@marcospb19 marcospb19 requested a review from figsoda October 11, 2022 23:46
@marcospb19 marcospb19 force-pushed the check-file-times-errors branch from ac65332 to 8af308e Compare October 12, 2022 00:05
@marcospb19
Copy link
Member Author

I'll reopen this one.

@marcospb19 marcospb19 closed this Oct 12, 2022
@figsoda figsoda deleted the check-file-times-errors branch October 12, 2022 00:07
@figsoda figsoda restored the check-file-times-errors branch October 12, 2022 00:07
@figsoda
Copy link
Member

figsoda commented Oct 12, 2022

sorry, muscle memories

@marcospb19 marcospb19 mentioned this pull request Oct 12, 2022
Merged
@figsoda figsoda deleted the check-file-times-errors branch October 12, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda Awaiting requested review from figsoda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcospb19 @figsoda