Skip to content

Fix single format compression #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2021
Merged

Fix single format compression #89

merged 1 commit into from
Oct 14, 2021

Conversation

marcospb19
Copy link
Member

Now working for formats that are not archives.

This now works:

ouch compress LICENSE LICENSE.xz

Fixes #87.

@marcospb19
Fix single format compression
937ac75 
Now working for formats that are not archives, like file.gz and file.xz
marcospb19
marcospb19 commented Oct 14, 2021
View reviewed changes
marcospb19
marcospb19 commented Oct 14, 2021
View reviewed changes
@vrmiguel
Copy link
Member

vrmiguel commented Oct 14, 2021 •
edited by marcospb19
Loading

The new changes do work but I noticed that a there's a panic when decompressing these kinds of files to a new folder

# Works
❯ cargo run -- c src/main.rs main.rs.xz 

# Panics
❯ cargo run -- d main.rs.xz -o some-new-folder
thread 'main' panicked at 'No such file or directory (os error 2)', src/error.rs:173:45
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Although that's probably a matter for another issue

@marcospb19
Copy link
Member Author

Sheesh, I will create another issue and merge this one to close #87 already.

@marcospb19 marcospb19 mentioned this pull request Oct 14, 2021
Closed
@vrmiguel vrmiguel merged commit c89c34a into master Oct 14, 2021
@vrmiguel vrmiguel added the hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event label Oct 14, 2021
@marcospb19 marcospb19 deleted the fix-single-format-compression branch October 14, 2021 21:19
@figsoda figsoda mentioned this pull request Nov 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrmiguel vrmiguel vrmiguel approved these changes

+1 more reviewer

@SpyrosRoum SpyrosRoum SpyrosRoum left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compressing a single file to a single format that's not tar or zip panics
3 participants
@marcospb19 @vrmiguel @SpyrosRoum