Skip to content

chore: Disable smart unpack when --dir is provided #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 4, 2025

Conversation

talis-fb
Copy link
Contributor

closes #322

Before, with Smart Unpack when --dir is provided:

image

Now:

image

When there are some conflict:

image

NOTE: When smart unpack is disabled the .tmp-ouch-xxx folder is no longer used inside --dir folder to hold unpacked files before renaming them. Instead, files are unpacked directly into the --dir folder.

@talis-fb talis-fb marked this pull request as ready for review April 3, 2025 00:22
@talis-fb talis-fb requested a review from marcospb19 April 4, 2025 17:59
Copy link
Member

@marcospb19 marcospb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@marcospb19 marcospb19 merged commit 3bf6aaa into ouch-org:main Apr 4, 2025
15 checks passed
gstreamer-github pushed a commit to sdroege/gstreamer-rs that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable smart unpack when --dir is provided
2 participants