Actions cleanup #3915
Merged
Actions cleanup #3915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Znote
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Works, but got a warning we might want to consider:
Build with vcpkg : .github#L1
windows-latest workflows will use windows-2022 soon. For more details, see actions/runner-images#4856
Also, vcpkg takes forever to compile on every action (12-25 minutes), we might want to upgrade to 10.1 and utilize the artifact cache, if I understand correctly it will prevent us rebuilding the same version of vcpkg on every action?
And since Macos isnt really that used, perhaps we can skip the luajit off checks and just keep luajit on for macos, saving us 2 actions?
3 tasks
|
@Znote I have a follow-up where I will investigate what to do with MacOS further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
lukka/run-vcpkgandlukka/run-cmaketo latest version compatible (there is newer v10 that would require changes to cmake)The packaged MacOS archive seems odd, or specifically, the build artifacts for MacOS coming from cmake are "odd", but I'm unable to verify that. You can check it out at https://github.com/DSpeichert/forgottenserver/releases/tag/v0.1.1