Skip to content

Add config for length player name #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4 commits merged into from
Nov 29, 2021
Merged

Add config for length player name #3760

4 commits merged into from
Nov 29, 2021

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Add config for lenght player name
  • Now we can easily change to 25 and have 12.x support

Zbizu
Zbizu reviewed Oct 26, 2021
View reviewed changes
ghost
ghost reviewed Nov 29, 2021
View reviewed changes
@ghost ghost changed the title Add config for lenght player name Add config for length player name Nov 29, 2021
@ghost ghost merged commit 4183bad into otland:master Nov 29, 2021
@ghost ghost deleted the player-name-lenght branch November 29, 2021 05:00
@Zbizu
Copy link
Contributor

Zbizu commented Nov 29, 2021 •
edited
Loading

there doesn't seem to be any real limit to names length from client side
Edit: 8192 chars probably, roughly enough to fill half of the screen. Also: XML supports <br /> tag in monster name, but ignores other tags.
obraz

I wasn't able to log in as a character with more than 70 chars in name though.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Zbizu Zbizu Zbizu left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramon-bernardo @Zbizu