Skip to content

Improve Monster::getDanceStep cache #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2021
Merged

Improve Monster::getDanceStep cache #3733

merged 4 commits into from
Oct 31, 2021

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Oct 15, 2021 •
edited
Loading

Pull Request Prelude

Changes Proposed

  • Improve random step cache, remove unnecessary allocation with reserve an exact heap size

@ramon-bernardo
Improve Monster::getDanceStep cache
80cf623 
- remove unnecessary heap allocation.
marmichalski
marmichalski reviewed Oct 15, 2021
View reviewed changes
@nekiro
Copy link
Member

nekiro commented Oct 28, 2021

#3734 (comment)

@DSpeichert DSpeichert merged commit 95de3cc into otland:master Oct 31, 2021
@ramon-bernardo ramon-bernardo deleted the mt-step-cache branch October 31, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSpeichert DSpeichert DSpeichert approved these changes

@nekiro nekiro nekiro approved these changes

+2 more reviewers

@marmichalski marmichalski marmichalski left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramon-bernardo @nekiro @DSpeichert @marmichalski