Skip to content

Conversation

Zbizu
Copy link
Contributor

@Zbizu Zbizu commented Sep 22, 2021

Changes Proposed

I'm sick of seeing .bak files every time I type git status. I also want to use my icon without risk of pushing it by accident. The thing with icon is already settled so we can safely ignore it.

ghost
ghost previously approved these changes Sep 22, 2021
@ghost ghost requested a review from DSpeichert September 22, 2021 19:00
@marmichalski
Copy link
Contributor

Stop being sick and setup your git properly.

https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer

.gitignore Outdated
#############
## TFS / OT
#############
config.lua
theforgottenserver.ico
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an icon actually checked in so this doesn't make sense.

@slawkens
Copy link
Contributor

slawkens commented Oct 9, 2021

.bak seems legit, would be useful for more people I guess.

.ico not, seems its already checked in repo as pointed by @DSpeichert

Co-authored-by: Evil Puncker <EPuncker@users.noreply.github.com>
@Zbizu Zbizu changed the title add notpad++ backups and tfs icon to gitignore add notpad++ backups to gitignore Oct 19, 2021
@Zbizu Zbizu changed the title add notpad++ backups to gitignore add notepad++ backups to gitignore Oct 19, 2021
@ghost ghost merged commit a26e2e1 into otland:master Oct 19, 2021
@Zbizu Zbizu deleted the patch-4 branch November 16, 2021 22:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants