Skip to content

added isKey itemtype #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
9 commits merged into from Oct 7, 2021
Merged

added isKey itemtype #3679

9 commits merged into from Oct 7, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 22, 2021

Pull Request Prelude

Changes Proposed

Issues addressed:
now you can add numbers to a key using /i silver key, 1234 for example.

ghost
ghost previously approved these changes Sep 22, 2021
View reviewed changes
@ghost ghost added the needs-testing Needs testing with screenshots label Sep 22, 2021
MillhioreBT
MillhioreBT previously approved these changes Sep 22, 2021
View reviewed changes
Zbizu
Zbizu approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@Zbizu Zbizu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I expected this game to have more keys, but either way it delivered
obraz

new /i works fine (tested with stackable items, unstackable items, fluid containers and keys)

Zbizu
Zbizu suggested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@Zbizu Zbizu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source edit is redundant as you can simply define function ItemType:isKey() return self:getType() == ITEM_TYPE_KEY end

DSpeichert
DSpeichert requested changes Oct 4, 2021
View reviewed changes
Copy link
Member

@DSpeichert DSpeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the C++ change in favor of Lua as zbizu pointed out

Emil Bergström added 2 commits October 5, 2021 03:54
Revert "Update luascript.h"
09ee89a 
This reverts commit 7b1def5.
Revert "Update luascript.cpp"
9ab6982 
This reverts commit 95355b7.
@ghost ghost dismissed stale reviews from MillhioreBT and themself via 9ab6982 October 5, 2021 01:55
@ghost ghost requested a review from DSpeichert October 5, 2021 02:02
DSpeichert
DSpeichert reviewed Oct 5, 2021
View reviewed changes
ghost
ghost reviewed Oct 6, 2021
View reviewed changes
ghost
ghost previously approved these changes Oct 6, 2021
View reviewed changes
@ghost ghost requested a review from DSpeichert October 6, 2021 14:38
@ghost ghost dismissed their stale review via d2898c3 October 6, 2021 16:53
@ghost ghost merged commit 963a528 into otland:master Oct 7, 2021
@Zbizu Zbizu mentioned this pull request Dec 20, 2021
Merged
3 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-testing Needs testing with screenshots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DSpeichert @Zbizu @MillhioreBT