Skip to content

new method: itemType:getRuneSpellName() #3666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Sep 19, 2021
Merged

new method: itemType:getRuneSpellName() #3666

1 commit merged into from
Sep 19, 2021

Conversation

Zbizu
Copy link
Contributor

@Zbizu Zbizu commented Sep 17, 2021

Pull Request Prelude

Changes Proposed

itemType:getRuneSpellName()

returns:

  • (string) spell words when used on named rune
  • (string) empty string when used on unnamed rune
  • (nil) when the item is not a rune

Issues addressed: It will be necessary for lua item descriptions.

@Zbizu
Copy link
Contributor Author

Zbizu commented Sep 19, 2021 •
edited
Loading

anything to correct here?

I have improvements for lua item descriptions code partially ready (~50%).

@ghost ghost merged commit 7b8e41f into otland:master Sep 19, 2021
@Zbizu Zbizu deleted the spellRunes branch September 22, 2021 18:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zbizu