Skip to content

Conversation

Zbizu
Copy link
Contributor

@Zbizu Zbizu commented May 2, 2020

closes #2998 without unnecessary code to implement another feature (the goal can be fully reproduced in onHear now)

unified sendCreatureSay so speaker == spectator check is not necessary anymore

onCreatureHear is now a boolean

same convention as in talkactions:

  • return true - the character line is displayed for the spectator
  • return false - it doesn't - creature:say(...) can now be used instead, to send a different message (return false has to be used after onSay events within onHear to prevent overflow)

@DSpeichert DSpeichert added the feature New feature or functionality label May 2, 2020
@Zbizu
Copy link
Contributor Author

Zbizu commented May 2, 2020

Note to testers: event onHear is disabled by default in events.xml

@Zbizu
Copy link
Contributor Author

Zbizu commented May 2, 2020

closing in favour of #3004 (leaving this information for reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

working on a new feature - onSay - creatureevent or event creature?
2 participants