Add parentheses to methods which are not purely-functional #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
xuwei-k
added a commit
that referenced
this pull request
Aug 2, 2015
Add parentheses to mathods which are not purely-functional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some methods depend on the current time, e.g.
DateTime.now.These methods are not a pure function, so in accordance with the Scala Style Guide, I want to call them with parentheses:
DateTime.now().However these methods are declared without parentheses, e.g.
def now = new DateTime, it forces us to call them without parentheses.In this PR, I declared above methods with parentheses.
Thanks!