Skip to content

Remove deprecated class RichMidnight #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2014
Merged

Remove deprecated class RichMidnight #63

merged 1 commit into from
May 17, 2014

Conversation

kmizu
Copy link

@kmizu kmizu commented May 17, 2014

  • RichMidnight had been planned to be removed in the anterior version

@xuwei-k
Copy link
Member

xuwei-k commented May 17, 2014 

[error] /home/travis/build/nscala-time/nscala-time/src/main/scala/com/github/nscala_time/time/Implicits.scala:79: not found: type RichDateMidnight
[error]   implicit def richDateMidnight(dm: DateMidnight): RichDateMidnight = new RichDateMidnight(dm)
[error]                                                    ^
[error] /home/travis/build/nscala-time/nscala-time/src/main/scala/com/github/nscala_time/time/Implicits.scala:79: not found: type RichDateMidnight
[error]   implicit def richDateMidnight(dm: DateMidnight): RichDateMidnight = new RichDateMidnight(dm)
[error]                                                                           ^
[error] two errors found

@kmizu
Copy link
Author

kmizu commented May 17, 2014

@xuwei-k Oops! I'll fix this error also and squash the commit.

@xuwei-k
Copy link
Member

xuwei-k commented May 17, 2014

LGTM

kmizu pushed a commit that referenced this pull request May 17, 2014
Merge pull request #63 from kmizu/r/remove-deprecated
7db649e 
Remove deprecated class `RichMidnight`
@kmizu kmizu merged commit 7db649e into nscala-time:master May 17, 2014
@kmizu kmizu deleted the r/remove-deprecated branch May 17, 2014 12:33
@kmizu kmizu mentioned this pull request May 25, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmizu @xuwei-k