This repository was archived by the owner on Aug 11, 2022. It is now read-only.
gyp: fix regex to match multi-digit versions #20948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
In node-gyp's v3.x branch we pinned request to <2.82.0 for compatibility with old Node.js versions. I'd suggest floating a patch here that relaxes that constraint so it can share a copy with npm (which is at 2.86.0, I think?) |
This fixes the regular expression matching in `xcode_emulation` to also handle version numbers with multiple-digit major versions which would otherwise break under use of XCode 10 Fixes: nodejs/node-gyp#1454
|
@bnoordhuis Certainly makes for a much easier-to-review change set. Done. |
zkat
approved these changes
Jun 28, 2018
There was a problem hiding this comment.
I'm going to accept this patch while nodejs/node-gyp#1484 or similar lands. I really don't want a bunch more copies of request in our tree.
|
That PR isn't going to land in node-gyp's v3.x branch so I closed it out, see discussion in that issue. This PR is a good way forward for now. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to node-gyp@3.6.3 to accommodate LLVM 10.0.0. Earlier versions of
node-gyp had a regular expression that did not match the version string
'10.0.0'. node-gyp@3.6.3 fixes this bug.
Refs: nodejs/node#21239
Refs: nodejs/node-gyp#1454
Refs: nodejs/node-gyp#1455
Refs: nodejs/node-gyp@293092c
Commit message from original patch: