Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

config: Enable config for suppressing update-notifier #20750

Merged
merged 2 commits into from
Jun 28, 2018
Merged

config: Enable config for suppressing update-notifier #20750

merged 2 commits into from
Jun 28, 2018

Conversation

travi
Copy link
Contributor

@travi travi commented May 25, 2018

@travi travi requested a review from a team as a code owner May 25, 2018 04:42
@travi
Copy link
Contributor Author

travi commented May 25, 2018

i'm happy to make any adjustments necessary, but this should be close. thanks for being open to the contribution

Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty much about right! Thank you!

bin/npm-cli.js Outdated
@@ -78,6 +78,7 @@
const pkg = require('../package.json')
let notifier = require('update-notifier')({pkg})
if (
npm.config.get('update-notifier'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'd like this to be further up so you don't even require the notifier package at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, that makes sense. how about combined w/ the conditional on line 77?

@travi
Copy link
Contributor Author

travi commented May 25, 2018

looks like i missed a simple syntax issue that npm t would have pointed out to me had i run it before pushing :\

ill have a fix up in a min

@travi
Copy link
Contributor Author

travi commented May 25, 2018

i'm having some trouble getting the tests to run correctly locally, but the travis output gives me proper insight with a longer feedback loop. i'll wrap those up tomorrow.

@travi
Copy link
Contributor Author

travi commented May 25, 2018

ah, it looks like a few tests that ensure the new config var is used somewhere in the code, but it doesnt seem to check files under bin/. do you want me to update the file search to include bin/ in addition to lib/?

@zkat
Copy link
Contributor

zkat commented May 25, 2018

Gonna cc @iarna on that q (I'm off work today)

@travi
Copy link
Contributor Author

travi commented May 25, 2018

sure thing. i'm happy to make the updates if thats best, but want to focus on what solution you see as most valuable.

enjoy the day off @zkat

@travi
Copy link
Contributor Author

travi commented May 26, 2018

i went ahead and included bin/ in the search for config usages and it does get the tests passing again. i made that change as a separate commit so i can easily back that out if you want to take a different approach. if you want to move forward with this approach, i can squash the two together, if you'd like.

@travi
Copy link
Contributor Author

travi commented Jun 4, 2018

anything else needed on my side to move this forward?

@zkat
Copy link
Contributor

zkat commented Jun 28, 2018

Everything looks good :)

@zkat zkat changed the base branch from latest to release-next June 28, 2018 21:43
@zkat zkat merged commit ce07933 into npm:release-next Jun 28, 2018
@travi
Copy link
Contributor Author

travi commented Jun 28, 2018

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants