-
Notifications
You must be signed in to change notification settings - Fork 3k
config: Enable config for suppressing update-notifier #20750
Conversation
i'm happy to make any adjustments necessary, but this should be close. thanks for being open to the contribution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty much about right! Thank you!
bin/npm-cli.js
Outdated
@@ -78,6 +78,7 @@ | |||
const pkg = require('../package.json') | |||
let notifier = require('update-notifier')({pkg}) | |||
if ( | |||
npm.config.get('update-notifier'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'd like this to be further up so you don't even require the notifier package at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, that makes sense. how about combined w/ the conditional on line 77?
looks like i missed a simple syntax issue that ill have a fix up in a min |
i'm having some trouble getting the tests to run correctly locally, but the travis output gives me proper insight with a longer feedback loop. i'll wrap those up tomorrow. |
ah, it looks like a few tests that ensure the new config var is used somewhere in the code, but it doesnt seem to check files under |
Gonna cc @iarna on that q (I'm off work today) |
sure thing. i'm happy to make the updates if thats best, but want to focus on what solution you see as most valuable. enjoy the day off @zkat |
i went ahead and included |
anything else needed on my side to move this forward? |
Everything looks good :) |
thanks! |
based on conversation from https://npm.community/t/npm-side-config-for-suppressing-update-notifier/75