Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Conversation

mmermerkaya
Copy link
Contributor

I investigated why npm sit was failing and fixed nested aliases not being dereferenced.

I see that the issue was already fixed in 6644cdb but I'm opening this PR to prevent similar issues in the future, and to restore the better looking 'sit': 'cit' :)

@mmermerkaya mmermerkaya requested a review from a team as a code owner May 4, 2018 22:09
@iarna
Copy link
Contributor

iarna commented May 10, 2018

I'm closing this for a moment, but I'll reopen it. I'm just working around a github bug.

@iarna iarna closed this May 10, 2018
@iarna iarna reopened this May 10, 2018
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I can think of this doing is creating cycles but, tbh, if we introduce one it'll be very obvious, very quickly. LGTM

@zkat zkat merged commit 91ef936 into npm:release-next May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants