Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

install: include number of audited packages in output #20570

Merged
merged 1 commit into from
May 16, 2018

Conversation

zkat
Copy link
Contributor

@zkat zkat commented May 10, 2018

Expects npm/npm-audit-report#12 for the full effect but can land without it. This bit only makes the installer print out the number of audited packages.

screen shot 2018-05-09 at 15 23 19

@zkat zkat requested a review from a team as a code owner May 10, 2018 00:56
@zkat zkat force-pushed the zkat/audit-output branch from 34f3d61 to 42ce8b9 Compare May 10, 2018 08:25
@legodude17
Copy link
Contributor

Wouldn't it make more sense for npm install to only audit installed packages?

@zkat
Copy link
Contributor Author

zkat commented May 10, 2018

no, because previously-installed packages may end up getting vulnerability notices long after having been installed. You'll want to find out when that happens.

@legodude17
Copy link
Contributor

Ah that makes sense.

Copy link
Contributor

@iarna iarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@zkat zkat merged commit 85b8616 into release-next May 16, 2018
@zkat zkat deleted the zkat/audit-output branch May 16, 2018 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants