Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

doc: Update npm-version.md #20140

Closed
wants to merge 1 commit into from
Closed

doc: Update npm-version.md #20140

wants to merge 1 commit into from

Conversation

srl295
Copy link
Contributor

@srl295 srl295 commented Mar 22, 2018 •
edited
Loading

Docs for npm version did not specify that package-lock.json also gets updated.

@srl295
Update npm-version.md
21757cd 
package-lock.json gets bumped, amirite?
@srl295 srl295 changed the title Update npm-version.md doc: Update npm-version.md Apr 6, 2018
@iarna iarna changed the base branch from master to release-next April 9, 2018 19:42
iarna pushed a commit that referenced this pull request Apr 9, 2018
@srl295 @iarna
doc: note that package-lock version gets touched by npm-version
290317c 
Credit: @srl295
PR-URL: #20140
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@srl295 @iarna
doc: note that package-lock version gets touched by npm-version
bf3fbae 
Credit: @srl295
PR-URL: #20140
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@srl295 @iarna
doc: note that package-lock version gets touched by npm-version
241e2f7 
Credit: @srl295
PR-URL: #20140
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@srl295 @iarna
doc: note that package-lock version gets touched by npm-version
df0228b 
Credit: @srl295
PR-URL: #20140
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@srl295 @iarna
doc: note that package-lock version gets touched by npm-version
ab489b7 
Credit: @srl295
PR-URL: #20140
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@srl295 @iarna
doc: note that package-lock version gets touched by npm-version
b271cdd 
Credit: @srl295
PR-URL: #20140
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@srl295 @iarna
doc: note that package-lock version gets touched by npm-version
8e21b19 
Credit: @srl295
PR-URL: #20140
Reviewed-By: @iarna
@iarna iarna force-pushed the release-next branch 3 times, most recently from 2e76172 to fe31e66 Compare April 13, 2018 20:20
@iarna iarna force-pushed the release-next branch 2 times, most recently from 63c9452 to 1b021d0 Compare April 21, 2018 00:09
@iarna
Copy link
Contributor

iarna commented May 3, 2018

Thank you for this! It shipped in 6.0.0! =)

@iarna iarna closed this May 3, 2018
@srl295 srl295 deleted the patch-1 branch May 4, 2018 00:18
@srl295
Copy link
Contributor Author

srl295 commented May 4, 2018

thank you for npm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@iarna iarna iarna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srl295 @iarna