Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

feat: allow optional @ prefix on scope #20082

Closed
wants to merge 1 commit into from
Closed

feat: allow optional @ prefix on scope #20082

wants to merge 1 commit into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 16, 2018

when providing a scope, e.g., during login, we encourage our users in docs to provide an @ prefix on scope:

npm login --scope=@foo

we don't currently allow a @ prefix for team commands, this is a slightly confusing disconnect that I felt was worth fixing.

@bcoe bcoe requested a review from a team as a code owner March 16, 2018 23:22
nzec
nzec approved these changes Mar 17, 2018
View reviewed changes
Copy link

@nzec nzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good RN!

iarna pushed a commit that referenced this pull request Apr 10, 2018
@iarna
feat: allow optional @ prefix on scope
266934c 
Credit: @bcoe
Reviewed-By: @zkat
PR-URL: #20082
iarna pushed a commit that referenced this pull request Apr 10, 2018
@iarna
feat: allow optional @ prefix on scope
1a78f57 
Credit: @bcoe
Reviewed-By: @zkat
PR-URL: #20082
iarna pushed a commit that referenced this pull request Apr 10, 2018
@iarna
feat: allow optional @ prefix on scope
2a71d18 
Credit: @bcoe
Reviewed-By: @zkat
PR-URL: #20082
iarna pushed a commit that referenced this pull request Apr 11, 2018
@iarna
feat: allow optional @ prefix on scope
d2d290b 
Credit: @bcoe
Reviewed-By: @zkat
PR-URL: #20082
iarna pushed a commit that referenced this pull request Apr 11, 2018
@iarna
feat: allow optional @ prefix on scope
6cd5760 
Credit: @bcoe
Reviewed-By: @zkat
PR-URL: #20082
iarna pushed a commit that referenced this pull request Apr 11, 2018
@iarna
feat: allow optional @ prefix on scope
05ff6c9 
Credit: @bcoe
Reviewed-By: @zkat
PR-URL: #20082
@iarna
Copy link
Contributor

iarna commented May 3, 2018

Thank you for this! It shipped in 6.0.0! =)

@iarna iarna closed this May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zkat zkat zkat approved these changes

@nzec nzec nzec approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcoe @iarna @zkat @nzec