This repository was archived by the owner on Aug 11, 2022. It is now read-only.
config: disable color by default when $NO_COLOR is set #19929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
reviewed
Feb 28, 2018
lib/config/defaults.js
Outdated
| @@ -130,7 +130,7 @@ Object.defineProperty(exports, 'defaults', {get: function () { | |||
|
|
|||
| cidr: null, | |||
|
|
|||
| color: true, | |||
| color: typeof(process.env.NO_COLOR) === 'undefined', | |||
There was a problem hiding this comment.
According to the error on CI, we might need to replace here with this: typeof process.env.NO_COLOR.
Refs: https://github.com/eslint/eslint/blob/master/docs/rules/no-extra-parens.md
There was a problem hiding this comment.
This is better off as !process.env.NO_COLOR or, if you want NO_COLOR="" to be truthy, process.env.NO_COLOR != null (with one =)
zkat
suggested changes
Feb 28, 2018
lib/config/defaults.js
Outdated
| @@ -130,7 +130,7 @@ Object.defineProperty(exports, 'defaults', {get: function () { | |||
|
|
|||
| cidr: null, | |||
|
|
|||
| color: true, | |||
| color: typeof(process.env.NO_COLOR) === 'undefined', | |||
There was a problem hiding this comment.
This is better off as !process.env.NO_COLOR or, if you want NO_COLOR="" to be truthy, process.env.NO_COLOR != null (with one =)
doc/misc/npm-config.md
Outdated
| @@ -278,7 +278,7 @@ This is a list of CIDR address to be used when configuring limited access tokens | |||
|
|
|||
| ### color | |||
|
|
|||
| * Default: true | |||
| * Default: true, unless the environment variable `NO_COLOR` is set | |||
There was a problem hiding this comment.
You can remove this. Please mention NO_COLOR in the description below, instead, and how to use it. I'd rather keep this describing what the "no action" default is.
This makes npm follow the NO_COLOR standard, as explained in http://no-color.org/ > All command-line software which outputs text with ANSI color added > should check for the presence of a NO_COLOR environment variable that, > when present (regardless of its value), prevents the addition of ANSI > color. npm already provides environment variables (npm_config_color=false) and options (--no-color) to disable coloring by default, but NO_COLOR is an comprehensive approach to disable colors for all tools.
zkat
approved these changes
Mar 6, 2018
zkat
pushed a commit
that referenced
this pull request
Mar 8, 2018
This makes npm follow the NO_COLOR standard, as explained in http://no-color.org/ > All command-line software which outputs text with ANSI color added > should check for the presence of a NO_COLOR environment variable that, > when present (regardless of its value), prevents the addition of ANSI > color. npm already provides environment variables (npm_config_color=false) and options (--no-color) to disable coloring by default, but NO_COLOR is an comprehensive approach to disable colors for all tools. PR-URL: #19929 Credit: @chneukirchen Reviewed-By: @zkat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes npm follow the NO_COLOR standard, as explained in
http://no-color.org/
npm already provides environment variables (npm_config_color=false) and
options (--no-color) to disable coloring by default, but NO_COLOR is an
comprehensive approach to disable colors for all tools.