This repository was archived by the owner on Aug 11, 2022. It is now read-only.
Consolidate code for stringifying package data and add tests #19907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces code duplication for detecting indentation and new lines in `package[-lock].json` and stringifying the data. This also improves performance on Unix systems since it avoids replacing newlines when it's not necessary. Tests have been added to test that `package[-lock].json` files are written to disk with their original line endings.
zkat
approved these changes
Feb 25, 2018
|
@zkat That's okay! Thanks for all the work you do :) |
zkat
pushed a commit
that referenced
this pull request
Mar 1, 2018
…ta and add tests (#19907) This reduces code duplication for detecting indentation and new lines in `package[-lock].json` and stringifying the data. This also improves performance on Unix systems since it avoids replacing newlines when it's not necessary. Tests have been added to test that `package[-lock].json` files are written to disk with their original line endings. PR-URL: #19907 Credit: @nwoltman Reviewed-By: @zkat
zkat
pushed a commit
that referenced
this pull request
Mar 8, 2018
…ta and add tests (#19907) This reduces code duplication for detecting indentation and new lines in `package[-lock].json` and stringifying the data. This also improves performance on Unix systems since it avoids replacing newlines when it's not necessary. Tests have been added to test that `package[-lock].json` files are written to disk with their original line endings. PR-URL: #19907 Credit: @nwoltman Reviewed-By: @zkat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces code duplication for detecting indentation and new lines in
package[-lock].jsonand stringifying the data. This also improves performance on Unix systems since it avoids replacing newlines when it's not necessary.Tests have been added to test that
package[-lock].jsonfiles are written to disk with their original line endings.Mostly based on #18943 rebased after #19904.