This repository was archived by the owner on Aug 11, 2022. It is now read-only.
fix: use detect-newline to detect newline instead of default \n #19904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
suggested changes
Feb 24, 2018
lib/install/save.js
Outdated
| @@ -122,7 +124,7 @@ function savePackageJson (tree, next) { | |||
| tree.package.bundleDependencies = deepSortObject(bundle) | |||
| } | |||
|
|
|||
| var json = JSON.stringify(tree.package, null, indent) + '\n' | |||
| var json = JSON.stringify(tree.package, null, indent) + newline | |||
There was a problem hiding this comment.
This does not replace all the newlines in the JSON file. I'm pretty sure you're gonna have to JSON.stringify(...).replace(/\n/g, newline) here, not just append the final one.
| @@ -3,6 +3,7 @@ | |||
| const createShrinkwrap = require('../shrinkwrap.js').createShrinkwrap | |||
| const deepSortObject = require('../utils/deep-sort-object.js') | |||
| const detectIndent = require('detect-indent') | |||
| const detectNewline = require('detect-newline') | |||
There was a problem hiding this comment.
This is not the only file that needs you to do this. You'll also have to add this to lib/shrinkwrap.js and lib/version.js, which both write out json files.
There was a problem hiding this comment.
i updated the PR to cover lib/shrinkwrap.js and lib/version.js as well.
4 tasks
zkat
approved these changes
Feb 24, 2018
|
#18943 from 4 months ago solved this in IMO a cleaner way and included tests. Guess you didn't see it... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
detect-newlineto detect newline instead of using the default\nwhich may cause npm to find thatpackagejsonstring to be different even though there is no change. (causing by the\nnewline)