Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Get rid of nock from .gitignore #19879

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Get rid of nock from .gitignore #19879

merged 1 commit into from
Mar 8, 2018

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Feb 21, 2018 •
edited
Loading

Remove nock from .gitignore which is already removed in package.json

@watilde watilde requested a review from a team as a code owner February 21, 2018 14:05
@watilde watilde changed the title Update bundle dependencies and update gitignore Get rid of nock from .gitignore Feb 22, 2018
zkat
zkat approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! nock was removed back in Dec 2015, so I think this is a pretty safe change here.

@zkat zkat changed the base branch from latest to release-next March 6, 2018 01:44
@zkat zkat merged commit 09edbc1 into npm:release-next Mar 8, 2018
zkat pushed a commit that referenced this pull request Mar 8, 2018
@watilde @zkat
gitignore: remove unused devDependency nock (#19879)
b4f707d 
PR-URL: #19879
Credit: @watilde
Reviewed-By: @zkat
@watilde watilde deleted the fix/deps-clean branch December 17, 2018 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@zkat zkat zkat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
target-latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@watilde @zkat