Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Fix #18781 - name and version optional #19726

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Fix #18781 - name and version optional #19726

merged 1 commit into from
Mar 8, 2018

Conversation

ngarnier
Copy link
Contributor

@ngarnier ngarnier commented Feb 1, 2018

This PR fixes #18781 by explaining that name and version are required only to publish your package.

@ngarnier ngarnier requested a review from a team as a code owner February 1, 2018 19:25
@iarna iarna force-pushed the release-next branch 2 times, most recently from 737dc85 to f526992 Compare February 20, 2018 05:14
@iarna iarna force-pushed the release-next branch 2 times, most recently from 3149016 to c493181 Compare February 21, 2018 21:31
@zkat zkat force-pushed the release-next branch 2 times, most recently from deb9ac5 to 7dff9d6 Compare February 22, 2018 17:23
@zkat zkat force-pushed the release-next branch 2 times, most recently from 7d2fd93 to 060cedb Compare March 2, 2018 03:46
zkat
zkat approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to include 👍 Thanks for the patch!

@zkat zkat merged commit 2fcf586 into npm:release-next Mar 8, 2018
zkat pushed a commit that referenced this pull request Mar 8, 2018
@ngarnier @zkat
docs: name and version optional (#19726)
5ec5dff 
Fixes: #18781
PR-URL: #19726
Credit: @ngarnier
Reviewed-By: @zkat
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@zkat zkat zkat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation target-latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngarnier @zkat