Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

fix npx prefix issue #19608

Merged
merged 1 commit into from
Mar 8, 2018
Merged

fix npx prefix issue #19608

merged 1 commit into from
Mar 8, 2018

Conversation

laggingreflex
Copy link
Contributor

@laggingreflex laggingreflex commented Jan 15, 2018

It was incorrectly calling node npx-cli prefix which led to downloading "prefix" package.

Instead it should be calling node npm-cli prefix

Fixes zkat/npx#148 zkat/npx#144

It was incorrectly calling `node npx-cli prefix` which led to downloading "prefix" package.

Instead it should be calling `node npm-cli prefix`
Copy link

@joeskeen joeskeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@woodsleaf
Copy link

woodsleaf commented Mar 4, 2018

node894-x64, webpack 4.0.1
Error

npx webpack src/index.js --output dist/bundle.js --mode production
npx: installed 1 in 3.062s
Path must be a string. Received undefined

im not sure may that not need fix, I`m reconfig package.json(add scripts), after it -> and that error go out. Be cause i use other command. just "npm run dev", or "npm run build".

{
"name": "_webdev",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"dev": "webpack --mode development",
"build": "webpack --mode production",
"test": "echo "Error: no test specified" && exit 1"
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"babel-preset-env": "^1.6.1",
"eslint": "^4.18.2",
"webpack": "^4.0.1",
"webpack-cli": "^2.0.10"
},
"dependencies": {
"d3": "^4.13.0"
}
}

@ryanpcmcquen
Copy link

Has the build issue been fixed?

Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 thank you. lol. 👍

@zkat zkat changed the base branch from latest to release-next March 8, 2018 08:30
@zkat zkat merged commit 9a7eb5e into npm:release-next Mar 8, 2018
zkat pushed a commit that referenced this pull request Mar 8, 2018
It was incorrectly calling `node npx-cli prefix` which led to downloading "prefix" package.

Instead it should be calling `node npm-cli prefix`

PR-URL: #19608
Credit: @laggingreflex
Reviewed-By: @zkat
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants