Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Better message when an "OTP" error occurs #19580

Closed
wants to merge 1 commit into from
Closed

Better message when an "OTP" error occurs #19580

wants to merge 1 commit into from

Conversation

jdeniau
Copy link
Contributor

@jdeniau jdeniau commented Jan 11, 2018 •
edited
Loading

When using 2FA, there is a weird Enter OTP: without further explaination.

This PR adds more logging and a small explaination on OTP

@jdeniau jdeniau requested a review from a team as a code owner January 11, 2018 14:45
@jdeniau
Copy link
Contributor Author

jdeniau commented Jan 30, 2018

I do not know why the tests are failing on COVERALLS_REPO_TOKEN="$COVERALLS_OPTIONAL_TOKEN".

It does not seems to be related to my changes but to the path of some binary files

iarna
iarna approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@iarna iarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a pretty reasonable user experience improvement. Thanks!

iarna pushed a commit that referenced this pull request Apr 12, 2018
@jdeniau @iarna
publish: Better message when an "OTP" error occurs
6bef538 
PR-URL: #19580
Credit: @jdeniau
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 12, 2018
@jdeniau @iarna
publish: Better message when an "OTP" error occurs
b5babf0 
PR-URL: #19580
Credit: @jdeniau
Reviewed-By: @iarna
@iarna
Copy link
Contributor

iarna commented May 3, 2018

Thank you for this! It shipped in 6.0.0! =)

@iarna iarna closed this May 3, 2018
@jdeniau jdeniau deleted the otp-explaination branch June 19, 2018 18:33
@jdeniau jdeniau mentioned this pull request Jul 1, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@iarna iarna iarna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdeniau @iarna