Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

added example for homepage #19475

Merged
merged 1 commit into from
Mar 8, 2018
Merged

added example for homepage #19475

merged 1 commit into from
Mar 8, 2018

Conversation

cg-cnu
Copy link
Contributor

@cg-cnu cg-cnu commented Dec 28, 2017 •
edited
Loading

Added example for homepage usage in package.json in the documentation.

@cg-cnu cg-cnu requested a review from a team as a code owner December 28, 2017 18:59
@cg-cnu
Copy link
Contributor Author

cg-cnu commented Dec 28, 2017

Hi, Not exactly sure why the build is failing. Let me know if I need to raise the pr to a different branch. Thanks!

@nwoltman
Copy link
Contributor

Don't worry @cg-cnu, the tests are just broken right now so everyone's builds are failing.

zkat
zkat approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the patch :)

@cg-cnu
Copy link
Contributor Author

cg-cnu commented Mar 6, 2018

Thanks @zkat 😄

@zkat zkat changed the base branch from latest to release-next March 8, 2018 08:34
@zkat zkat merged commit b66f4e9 into npm:release-next Mar 8, 2018
zkat pushed a commit that referenced this pull request Mar 8, 2018
@cg-cnu @zkat
docs: added example for homepage pkgjson field(#19475)
ffa84cd 
PR-URL: #19475
Credit: @cg-cnu
Reviewed-By: @zkat
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@zkat zkat zkat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation target-latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cg-cnu @nwoltman @zkat