Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Holidays are for all JS, not just Node #19448

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Holidays are for all JS, not just Node #19448

merged 1 commit into from
Mar 8, 2018

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Dec 22, 2017

Update the easter egg to match npm's expanded role.

@isaacs isaacs requested a review from a team as a code owner December 22, 2017 21:48
zkat
zkat approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dat branding

@zkat zkat changed the base branch from latest to release-next March 6, 2018 02:44
@zkat zkat merged commit dd1694f into release-next Mar 8, 2018
@zkat zkat deleted the seasons-greetings-for-all branch March 8, 2018 08:35
zkat pushed a commit that referenced this pull request Mar 8, 2018
@isaacs @zkat
xmas: Holidays are for all JS, not just Node (#19448)
b9d0c0c 
PR-URL: #19448
Credit: @isaacs
Reviewed-By: @zkat
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@zkat zkat zkat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
target-latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaacs @zkat