+1 👍

make-fetch-happen doesn't use request, it uses http-proxy-agent and https-proxy-agent in conjunction with node-fetch-npm. I don't see mention of this option in the docs for any of those… have you verified that this patch actually works?

No idea where I got that from, maybe it was used in an old npm version? I tested it and it worked, but with this I'll just reconfirm it :-) However make-fetch-happen has documentation on this feature so I'm pretty sure it works :-) also if request is out of the picture.

@iarna Tested again and it works.

Any feedback on this @iarna ?

Is anybody going to look at this at some point? I'd prefer not to have to switch to yarn.

I just test this PR in my environment where we use a private repo for our private dependencies.
This private repo in inside our network and NPM has to bypass the proxy to access it.
Everything work fine with this PR.
We used to use environment variables to set the proxy configuration (HTTP_PROXY, HTTPS_PROXY and NO_PROXY) but since a few updates, this does not work anymore so this PR is very important for us.

+1 from me. I need NPM to work with an external proxy and a local registry and we can't use the environment variables because that breaks git (which needs to talk to a local git server) and other things.

Eagerly awaiting this as well

@sebinsua as far a I know Yarn does not support this? But maybe I should create a PR for them as well.

as far a I know Yarn does not support this? But maybe I should create a PR for them as well.

@Saturate They only support the NO_PROXY environment variable in the pre-release of 1.4.1. They don't yet support a configuration option of noProxy and, in fact, setting any of the proxy configuration via config stops the fallback to the environment variables. However, I've been able to achieve what I need by just using the environment variables.

@iarna did you have a chance to review this?

@sebinsua thanks, I'll take a look at it soon, if this goes no further as it would help me with a lot of the big corporate environments where they lock most things down, and everything has to be proxied.

+1 👍

For the rest of y'all: npm has supported the environment variable NO_PROXY for a while, so if you don't have this patch, you can still set your no-proxy config by using that env var instead of an npm arg (NO_PROXY="..." npm install ...)