This repository was archived by the owner on Aug 11, 2022. It is now read-only.
fix: Output package.json with original line endings #18943
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this going to get merged this century? |
Same for package-lock.json and npm-shrinkwrap.json Detect the line endings used in the original file and use the same line endings when updating the file.
9776641 to
770200d
Compare
|
@nwoltman oh no! I'm sorry I didn't see this before I saw the other one. We were gonna go through all our PRs for the next release and stacks work different than queues :< I'm really happy that you wrote a test for this, and that's awesome -- would you be willing to rebase the test onto the patch for the other detection PR? I'll definitely take that and I'm really grateful you took the time to do this. <3 |
|
Thank you for your kind response @zkat. I understand why the other PR showed up on your radar before this one. I'll rebase these changes using the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same for
package-lock.jsonandnpm-shrinkwrap.json.Detect the line endings used in the original file and use the same line endings when updating the file.
Fixes #17161