This repository was archived by the owner on Aug 11, 2022. It is now read-only.
Clarify that "files" is an exclusive list of files #18407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't clear that files not included in the "files" field are excluded.
|
Just out of curiosity: I don't understand what else the text could have meant before your change. Could you elaborate? |
|
I think what they're trying to communicate is that if you use |
zkat
approved these changes
Mar 6, 2018
zkat
pushed a commit
that referenced
this pull request
Mar 8, 2018
It wasn't clear that files not included in the "files" field are excluded. PR-URL: #18407 Credit: @bmacnaughton Reviewed-By: @zkat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't clear that files not included in the "files" field are excluded if the field is present.