Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Jun 29, 2017

Fixes: #17168

@zkat zkat added the npm5 label Jun 29, 2017
@zkat zkat requested a review from iarna June 29, 2017 04:09
@iarna
Copy link
Contributor

iarna commented Jun 29, 2017

I wish the "I search and replaced var to const" part was a separate commit. It's v hard to see what your changes are as it is.

@zkat
Copy link
Contributor Author

zkat commented Jun 29, 2017

@iarna +exports.exec = BB.promisify(execGit) is the only actual change in that file.

I can pull that out and just do it separately, tho 👍

function addLocalFile (file, options, ignoreFailure) {
const p = git.exec(['add', path.join(npm.localPrefix, file)], options)
return ignoreFailure
? p.catch(() => {})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is the new bit! 👍

@zkat zkat merged commit 90bd11c into release-next Jun 29, 2017
@zkat zkat deleted the zkat/version-with-ignored-lock branch June 29, 2017 15:13
zkat added a commit that referenced this pull request Jun 29, 2017
zkat added a commit that referenced this pull request Jul 5, 2017
zkat added a commit that referenced this pull request Jul 5, 2017
@patrykkopycinski
Copy link

patrykkopycinski commented Aug 16, 2017

regression in 5.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants