This repository was archived by the owner on Aug 11, 2022. It is now read-only.
Makefile: dont call destructive 'uninstall' on clean #16540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'clean' rule calls 'uninstall', which attemts ***destructive***
operation in the host system and fails if run as unprivileged user.
nekrad@orion:~/src/packaging/pkg/npm.git$ make clean
rm -rf node_modules/marked node_modules/.bin/marked .building_marked
rm -rf node_modules/marked-man node_modules/.bin/marked-man .building_marked-man
rm -rf
.building_marked
.building_marked-man
html/doc
man
nodejs cli.js rm npm -g -f
npm WARN using --force I sure hope you know what you are doing.
npm ERR! path /usr/lib/nodejs/nodejs-7.9/lib
npm ERR! code EACCES
npm ERR! errno -13
npm ERR! syscall mkdir
npm ERR! Error: EACCES: permission denied, mkdir '/usr/lib/nodejs/nodejs-7.9/lib'
npm ERR! { Error: EACCES: permission denied, mkdir '/usr/lib/nodejs/nodejs-7.9/lib'
npm ERR! errno: -13,
npm ERR! code: 'EACCES',
npm ERR! syscall: 'mkdir',
npm ERR! path: '/usr/lib/nodejs/nodejs-7.9/lib' }
npm ERR!
npm ERR! Please try running this command again as root/Administrator.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/nekrad/.npm/_logs/2017-05-05T13_08_46_485Z-debug.log
make: *** [uninstall] Error 243
iarna
approved these changes
Jun 30, 2017
There was a problem hiding this comment.
This seems reasonable to me.
As a dev, literally the only thing I use the makefile for is make publish and make release (for upstreaming to Node.js). We should update the Makefile to reflect the reality of our use. (It's just sitting there, encouraging contributors to try to use it and then it goes and does surprising thigns…)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'clean' rule calls 'uninstall', which attemts destructive
operation in the host system and fails if run as unprivileged user.
nekrad@orion:~/src/packaging/pkg/npm.git$ make clean
rm -rf node_modules/marked node_modules/.bin/marked .building_marked
rm -rf node_modules/marked-man node_modules/.bin/marked-man .building_marked-man
rm -rf
.building_marked
.building_marked-man
html/doc
man
nodejs cli.js rm npm -g -f
npm WARN using --force I sure hope you know what you are doing.
npm ERR! path /usr/lib/nodejs/nodejs-7.9/lib
npm ERR! code EACCES
npm ERR! errno -13
npm ERR! syscall mkdir
npm ERR! Error: EACCES: permission denied, mkdir '/usr/lib/nodejs/nodejs-7.9/lib'
npm ERR! { Error: EACCES: permission denied, mkdir '/usr/lib/nodejs/nodejs-7.9/lib'
npm ERR! errno: -13,
npm ERR! code: 'EACCES',
npm ERR! syscall: 'mkdir',
npm ERR! path: '/usr/lib/nodejs/nodejs-7.9/lib' }
npm ERR!
npm ERR! Please try running this command again as root/Administrator.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/nekrad/.npm/_logs/2017-05-05T13_08_46_485Z-debug.log
make: *** [uninstall] Error 243