Skip to content

feat: add a problem matcher for tap output #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2022
Merged

feat: add a problem matcher for tap output #160

merged 1 commit into from
Aug 16, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Aug 16, 2022

this gives us annotations for failing tests that allow us to very quickly review and locate them

@nlf nlf requested a review from a team as a code owner August 16, 2022 19:27
@nlf
Copy link
Contributor Author

nlf commented Aug 16, 2022

example here: https://github.com/nlf/example-repo/actions/runs/2870404521

fritzy
fritzy approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@fritzy fritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nlf nlf merged commit 8176e44 into main Aug 16, 2022
@nlf nlf deleted the nlf/tap-problem-matcher branch August 16, 2022 20:04
@github-actions github-actions bot mentioned this pull request Aug 16, 2022
Merged
@github-actions github-actions bot mentioned this pull request Aug 25, 2022
Closed
@lukekarrys lukekarrys mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@fritzy fritzy fritzy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlf @fritzy