Skip to content

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Dec 16, 2024

Resurfaces an old PR that updated tap 16 -> 19 (still not sure what's needed from that until i see the diff.
Had to do some googling to find why /* istanbul ignore next */ doesn't work anymore.

tapjs/tapjs#1027

got some node 22
failures - ENOENT: no such file or directory, open '/home/runner/work/template-oss/template-oss/.tap/fixtures/test-apply-esm.js-basic/file.js'

doesn't work on 20.5.0 because of tapjs/tapjs#1028

@reggi reggi requested a review from a team as a code owner December 16, 2024 16:51
@reggi reggi closed this Jan 23, 2025
@reggi reggi reopened this Jan 23, 2025
@reggi reggi changed the title deps: tap@21.0.1 feat!: bumps engines to ^20.17.0 || >=22.9.0 and upgrades tap@21.0.1 Jan 27, 2025
@reggi reggi changed the title feat!: bumps engines to ^20.17.0 || >=22.9.0 and upgrades tap@21.0.1 deps: tap@21.0.1 Jan 27, 2025
wraithgar pushed a commit that referenced this pull request Jan 29, 2025
@wraithgar wraithgar merged commit 83c0c7d into main Jan 30, 2025
17 checks passed
@wraithgar wraithgar deleted the reggi/tap19 branch January 30, 2025 16:55
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
wraithgar pushed a commit that referenced this pull request Jan 30, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.24.0](v4.23.6...v4.24.0)
(2025-01-30)
### Features
*
[`402d480`](402d480)
[#500](#500) engines to ^20.17.0
|| >=22.9.0 (#500) (@reggi)
### Dependencies
*
[`83c0c7d`](83c0c7d)
[#498](#498) `tap@21.0.1` (#498)
(@reggi)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants