Skip to content

Improve output parameter handling #5645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve output parameter handling #5645

wants to merge 1 commit into from

Conversation

NinoFloris
Copy link
Member

@NinoFloris NinoFloris commented Mar 25, 2024 •
edited
Loading

Moved the output reading into the command itself and added support via a virtual for reading values as a generic type for generic parameters.

Probably want to add some tests for the latter, TODO.

Regarding

    // Not sure where this odd behavior comes from: all output parameters which did not get matched by
    // name now get populated with column values which weren't matched. Keeping this for backwards compat,
    // opened #2252 for investigation.

I've added commentary on why it exists, people likely depend on this behavior as well. An unfortunate holdover from when we didn't have positional parameters.

We also have a test depending on it https://github.com/npgsql/npgsql/blob/main/test/Npgsql.Tests/FunctionTests.cs#L119.
Note how the set consists of named parameters while the columns are unnamed.

Related to #2252

@NinoFloris NinoFloris added this to the 9.0.0 milestone Mar 25, 2024
@NinoFloris NinoFloris force-pushed the output-parameter-handling branch 4 times, most recently from 2a86b31 to 5fb2d86 Compare March 28, 2024 18:21
@NinoFloris
Improve output parameter handling
42bc515 
Including support for generic parameters
Fixes #2252
@NinoFloris NinoFloris force-pushed the output-parameter-handling branch from 5fb2d86 to 42bc515 Compare June 24, 2024 23:17
@NinoFloris NinoFloris mentioned this pull request Sep 26, 2024
Merged
@vonzshik vonzshik modified the milestones: 9.0.0, 10.0.0 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji Awaiting requested review from roji roji is a code owner

@vonzshik vonzshik Awaiting requested review from vonzshik vonzshik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NinoFloris @vonzshik