Skip to content

Add a fast path for PreparedStatementManager.TryGetAutoPrepared #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2024
Merged

Add a fast path for PreparedStatementManager.TryGetAutoPrepared #5395

merged 2 commits into from
Mar 27, 2024

Conversation

vonzshik
Copy link
Contributor

Locally I see about 2% improvements:


BenchmarkDotNet v0.13.10, Windows 10 (10.0.19045.3636/22H2/2022Update)
AMD Ryzen 9 5900X, 1 CPU, 24 logical and 12 physical cores
.NET SDK 8.0.100-rc.1.23455.8
  [Host]     : .NET 8.0.0 (8.0.23.41904), X64 RyuJIT AVX2
  DefaultJob : .NET 8.0.0 (8.0.23.41904), X64 RyuJIT AVX2
Method FastAutoPrepare Mean Error StdDev
Read False 28.89 μs 0.533 μs 0.499 μs
Read True 28.32 μs 0.549 μs 0.514 μs

@vonzshik vonzshik requested a review from roji as a code owner November 14, 2023 11:49
gfoidl
gfoidl reviewed Nov 15, 2023
View reviewed changes
vonzshik
vonzshik commented Nov 15, 2023
View reviewed changes
@NinoFloris NinoFloris mentioned this pull request Nov 15, 2023
Merged
@NinoFloris NinoFloris force-pushed the add-auto-prepare-fast-path branch from d4065a2 to d7035ab Compare March 27, 2024 17:57
@NinoFloris NinoFloris merged commit f6d8b1b into main Mar 27, 2024
@NinoFloris NinoFloris deleted the add-auto-prepare-fast-path branch March 27, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NinoFloris NinoFloris NinoFloris approved these changes

@roji roji Awaiting requested review from roji roji is a code owner

+1 more reviewer

@gfoidl gfoidl gfoidl left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vonzshik @NinoFloris @gfoidl