Skip to content

Hacky exposing of enum type mappings for EFCore.PG #5278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

Hacky exposing of enum type mappings for EFCore.PG #5278

merged 1 commit into from
Sep 25, 2023

Conversation

roji
Copy link
Member

@roji roji commented Sep 25, 2023 •
edited
Loading

This is a 100% awful PR - it's just there to make EFCore.PG 8.0 work. We should definitely think about how we clean this up in the future.

@roji roji requested a review from NinoFloris September 25, 2023 21:20
@roji roji requested a review from vonzshik as a code owner September 25, 2023 21:20
vonzshik
vonzshik approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@vonzshik vonzshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

NinoFloris
NinoFloris approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@NinoFloris NinoFloris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it sucks, approved!

@roji roji merged commit 78ee2c2 into npgsql:main Sep 25, 2023
@roji roji deleted the EnumHackiness branch September 25, 2023 21:51
@NinoFloris NinoFloris added this to the 8.0.0 milestone Nov 7, 2023
@kenbailey kenbailey mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NinoFloris NinoFloris NinoFloris approved these changes

@vonzshik vonzshik vonzshik approved these changes

Assignees

@roji roji

Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@roji @NinoFloris @vonzshik