Add more hover and completion tests #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the new overload grouping
…andard hover positions
Yes, I think most "bugs" there are better thought of as weird but expected (and sometimes helpful?) behaivour. Thanks a lot for writing all these tests! It's a heroic effort 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more tests for hover and completion on: buffers, images, sampler, arrays.
Also fixes parsing of function overloads in test logic after the output was changed in cedaea8.
Didn't catch any new bugs other than this minor one, but I wrote this for completeness sake.
If you have any ideas as to what else we should test, please feel free to give suggestions.
I'm thinking of maybe testing hover/completion in presence of macros and includes next, but I'll likely start from the discussion in #30 just to settle on what to expect there.
We should probably close #32 if this is merged. All the unfixed bugs are still "documented" in tests with
ExpectFail, so we can deal with them later.