feat: throw error when maxRedirections is used with undici.request() #4311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maxRedirections option was removed in v7 but no error was thrown when users tried to use it, making migration confusing. Now throws a clear error message directing users to use the redirect interceptor instead. Fixes #4310 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>
ronag
approved these changes
Jun 30, 2025
ronag
reviewed
Jun 30, 2025
CLAUDE.md
Outdated
| **WebAssembly Components:** | ||
| - HTTP parser is WebAssembly-based | ||
| - Requires Docker to rebuild | ||
| - Pre-built binaries included in `lib/llhttp/` |
metcoder95
approved these changes
Jun 30, 2025
The maxRedirections option was removed in v7 but no error was thrown when users tried to use it, making migration confusing. Now throws a clear error message directing users to use the redirect interceptor instead. Changes: - Add validation in Request constructor to throw error for maxRedirections > 0 - Allow maxRedirections: 0 for internal fetch usage - Update redirect interceptor to work with new validation - Fix failing tests by removing maxRedirections from request options - Add CLAUDE.md to .gitignore Fixes #4310 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>
3d4aa95 to
7cee925
Compare
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Ethan-Arrowood
requested changes
Jun 30, 2025
|
@Ethan-Arrowood good spot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maxRedirections option was removed in v7 but no error was thrown when users tried to use it, making migration confusing. Now throws a clear error message directing users to use the redirect interceptor instead.
Fixes #4310
🤖 Generated with Claude Code
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status