docs: fix interceptor order description in compose method #4251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The request goes bottom => top and the response goes top => bottom. Would be nice to have a visualization. |
ronag
approved these changes
Jun 2, 2025
The documentation incorrectly stated that the first interceptor would be called first, but due to function composition, the last interceptor in the array is actually called first. Added ASCII art diagram showing the interceptor stack and request flow to make the execution order clear. Fixes #4241 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>
cfbdde2 to
1075912
Compare
|
@ronag I've asked Claude to draw it. I guess it's better than nothing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation incorrectly stated that the first interceptor would be called first, but due to function composition, the last interceptor in the array is actually called first.
Fixes #4241
🤖 Generated with Claude Code
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status