Query unaware interceptors cache fix #4240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
May 26, 2025
lib/util/cache.js
Outdated
| } else if (value !== undefined && value !== null) { | ||
| params.append(key, String(value)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Are you sure we don't have this already serialized somewhere? We might be wasting some resources. Also, I would prefer if we used the previous logic so we are sure the actual result is identical.
There was a problem hiding this comment.
Good idea! Looks like we already have a util function to handle serialization.
metcoder95
approved these changes
May 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Addresses #4209 (interceptors.cache is not aware of query)
Changes
makeCacheKeyfunction to include query parameters in cache key generation.Features
N/A
Bug Fixes
Fixed cache interceptor to properly handle query parameters in cache keys, preventing incorrect cache hits when requests have different query parameters.
Breaking Changes and Deprecations
N/A
Status